Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct treatment of QuoteNode in stmt position #140

Merged
merged 1 commit into from
Apr 9, 2023
Merged

Correct treatment of QuoteNode in stmt position #140

merged 1 commit into from
Apr 9, 2023

Conversation

Keno
Copy link
Collaborator

@Keno Keno commented Apr 9, 2023

Similar to #138. QuoteNode's value does actually need to be wrapped in ZeroBundle, otherwise it'll be at the wrong diff level.

Similar to #138. QuoteNode's value does actually need to be wrapped in ZeroBundle,
otherwise it'll be at the wrong diff level.
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3751c0f) 51.13% compared to head (ae39e7d) 51.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   51.13%   51.13%           
=======================================
  Files          27       27           
  Lines        2677     2677           
=======================================
  Hits         1369     1369           
  Misses       1308     1308           
Impacted Files Coverage Δ
src/codegen/forward_demand.jl 29.90% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Keno Keno merged commit 5373279 into main Apr 9, 2023
@oscardssmith oscardssmith deleted the kf/qnstmt branch April 10, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant