Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust to the latest JuliaLang/julia#master #114

Merged
merged 1 commit into from
Mar 28, 2023
Merged

adjust to the latest JuliaLang/julia#master #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/codegen/forward_demand.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ function forward_diff_uncached!(ir::IRCode, interp, irsv::IRInterpretationState,
# Incidence analysis through the rt call
# TODO: frule_mi is wrong here, should be the mi of the caller
frule_rt = info.frule_call.rt
improve_frule_rt = CC.concrete_eval_invoke(interp, frule_call, frule_mi, irsv)
(improve_frule_rt, nothrow) = CC.concrete_eval_invoke(interp, frule_call, frule_mi, irsv)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put this behind a version check?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Diffractor supposed to work only with Julia nightly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was supposed to be 1.8 or up, but @Keno should confirm.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we're nightly only

if improve_frule_rt !== nothing
frule_rt = improve_frule_rt
end
Expand Down