removes @pure and some miscelanious cleanups
#108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI doesn't pass on nightly without #107, but it passes locally if you rebase on the other it. |
oscardssmith
force-pushed
the
atone-for-our-sins
branch
from
eb062fa to
cc98517
Compare
oscardssmith
force-pushed
the
atone-for-our-sins
branch
from
cc98517 to
edb563d
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
- Coverage 51.52% 50.47% -1.05%
==========================================
Files 27 27
Lines 2696 2649 -47
==========================================
- Hits 1389 1337 -52
- Misses 1307 1312 +5
☔ View full report in Codecov by Sentry. |
|
I think this is ready to merge. |
|
CI is failing. |
staticfloat
force-pushed
the
atone-for-our-sins
branch
from
edb563d to
eb7f7f6
Compare
|
CI passes now, so I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is NFC, just removing a lot of uses of
@purethat @Keno isn't allowed to write since he isn't Jamison (and they were probably from before the effect system).