Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve inferability of forward mode data structures #104

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Conversation

Keno
Copy link
Collaborator

@Keno Keno commented Jan 19, 2023

None of this is particularly, pretty, but these changes help the compiler constprop things better, so let's do this for now. We can revisit in the future when the compiler learns more tricks.

None of this is particularly, pretty, but these changes help the
compiler constprop things better, so let's do this for now.
We can revisit in the future when the compiler learns more tricks.
@codecov-commenter
Copy link

Codecov Report

Base: 51.33% // Head: 50.87% // Decreases project coverage by -0.46% ⚠️

Coverage data is based on head (b3e6c9e) compared to base (c6f1a48).
Patch coverage: 34.78% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   51.33%   50.87%   -0.46%     
==========================================
  Files          27       27              
  Lines        2628     2632       +4     
==========================================
- Hits         1349     1339      -10     
- Misses       1279     1293      +14     
Impacted Files Coverage Δ
src/extra_rules.jl 44.54% <0.00%> (ø)
src/stage1/forward.jl 70.00% <0.00%> (-1.92%) ⬇️
src/tangent.jl 24.52% <57.14%> (-6.61%) ⬇️
src/codegen/forward.jl 92.53% <0.00%> (-1.50%) ⬇️
src/codegen/reverse.jl 92.85% <0.00%> (-0.48%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Keno Keno merged commit 0241872 into main Jan 19, 2023
@oscardssmith oscardssmith deleted the kf/inferability branch January 19, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants