Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward_demand: Implement bundle truncation #101

Merged
merged 1 commit into from
Jan 11, 2023
Merged

forward_demand: Implement bundle truncation #101

merged 1 commit into from
Jan 11, 2023

Conversation

Keno
Copy link
Collaborator

@Keno Keno commented Jan 7, 2023

Also make the canonical 1-bundle use the TaylorBundle type. The types are isomorphic, but since ∂xⁿ{1}() returns a TaylorBundle, this helps type stability.

Also make the canonical 1-bundle use the TaylorBundle type. The
types are isomorphic, but since `∂xⁿ{1}()` returns a TaylorBundle,
this helps type stability.
@codecov-commenter
Copy link

Codecov Report

Base: 51.49% // Head: 51.33% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (dade754) compared to base (b293bbd).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   51.49%   51.33%   -0.17%     
==========================================
  Files          27       27              
  Lines        2604     2628      +24     
==========================================
+ Hits         1341     1349       +8     
- Misses       1263     1279      +16     
Impacted Files Coverage Δ
src/tangent.jl 31.13% <0.00%> (-1.55%) ⬇️
src/codegen/forward_demand.jl 30.85% <34.37%> (+0.67%) ⬆️
src/interface.jl 69.09% <100.00%> (ø)
src/stage1/forward.jl 71.91% <100.00%> (ø)
src/stage1/generated.jl 72.92% <0.00%> (+0.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Keno Keno merged commit 7356cba into main Jan 11, 2023
@oscardssmith oscardssmith deleted the kf/trunc branch January 11, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants