Dispatch on StaticArray instead of SArray #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
This was referenced Feb 4, 2019
jrevels
reviewed
Feb 8, 2019
| @@ -79,7 +79,7 @@ shape information. If you want to allocate storage yourself, use the `DiffResult | |||
| constructor instead. | |||
| """ | |||
| JacobianResult(x::AbstractArray) = DiffResult(similar(x), similar(x, length(x), length(x))) | |||
| JacobianResult(x::SArray{<:Any,T,<:Any,L}) where {T,L} = DiffResult(x, zeros(SMatrix{L,L,T})) | |||
| JacobianResult(x::StaticArray) = DiffResult(x, zeros(StaticArrays.similar_type(typeof(x), Size(length(x),length(x))))) | |||
There was a problem hiding this comment.
will the length(x) here cause the size parameter of the resulting array to be uninferrable, or does constant prop take care of that for us?
There was a problem hiding this comment.
Constant prop seems to take care of it (as I assumed without worrying much 😄):
using DiffResults, StaticArrays, Test
v = SVector([1, 2.5, 4])
@inferred DiffResults.JacobianResult(v)
@code_warntype DiffResults.JacobianResult(v)outputs
Body::DiffResults.ImmutableDiffResult{1,SArray{Tuple{3},Float64,1,3},Tuple{SArray{Tuple{3,3},Float64,2,9}}}
1 ─ %1 = %new(DiffResults.ImmutableDiffResult{1,SArray{Tuple{3},Float64,1,3},Tuple{SArray{Tuple{3,3},Float64,2,9}}}, x, ([0.0 0.0 0.0; 0.0 0.0 0.0; 0.0 0.0 0.0],))::DiffResults.ImmutableDiffResult{1,SArray{Tuple{3},Float64,1,3},Tuple{SArray{Tuple{3,3},Float64,2,9}}}
└── return %1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only
SArrays are supported and no otherStaticArrays such asSLArrays (https://github.com/JuliaDiffEq/LabelledArrays.jl). Together with a similar PR to ForwardDiff this seems to fix issues I experienced withSLArrays without breaking existingSArraysupport. However, since we do not dispatch on the mutability of the static arrays unfortunately evenDiffResults for mutable static arrays such asMArraywill be immutable.