You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frule_test currently requires the primal output of frule of f to be exactly equal to the output of f. We previously relaxed this requirement for rrule_test (#33), and this PR just uses the same check for frule_test.
The ChainRules test suite still passes for me with this change.
Hmm my concern is that this is going to break when the functions output objects for which isapprox is not defined, such as Tuples. I don't think that we test enough things in this package to be sure that this won't break lots of things downstream unfortunately. Possibly we need to implement our own function to check approximate equality. @oxinabox any thoughts?
Yes, rrule_test has this same limitation. One easy thing we could do for both frule_test and rrule_test would be conduct a strict equality check first, followed by an approximate equality check if that fails. This would ensure that this test passes for everything it currently passes for.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frule_testcurrently requires the primal output offruleoffto be exactly equal to the output off. We previously relaxed this requirement forrrule_test(#33), and this PR just uses the same check forfrule_test.The ChainRules test suite still passes for me with this change.