Avoid lowering to Base.rest(), as it infers poorly
#721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is This is probably fine as both the nominally correct type has However, right now CI is broken due to not having #721 in yet. It is pretty bad that this breaks inference so badly, it looks so idiomatic. Can we open an upstream issue in JuliaLang/julia about it? |
oxinabox
approved these changes
Jun 2, 2023
|
I have opened an error report and an MWE here: JuliaLang/julia#50046 |
While it would be best to fix `Base.rest()` to be able to infer properly, at the moment the destructuring with a splat in the arguments to this `frule` end up causing inference issues in Diffractor.
oxinabox
force-pushed
the
sf/no_rest_for_the_wicked
branch
from
46f80e6 to
bc57832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it would be best to fix
Base.rest()to be able to infer properly, at the moment the destructuring with a splat in the arguments to thisfruleend up causing inference issues in Diffractor.