Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly unthunk in a few rules #670

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Explicitly unthunk in a few rules #670

merged 3 commits into from
Aug 25, 2022

Conversation

mcabbott
Copy link
Member

@mcabbott mcabbott commented Aug 25, 2022 •
edited
Loading

The rrule for + would silently unthunk N times, by calling reshape. (Maybe test_rrule should have a thunk which counts to test for such mistakes?)

And most broadcasting would fail on thunks, by calling something like ndims(@thunk [1,2]). (Not sure why this didn't cause failures.)

@github-actions github-actions bot added the needs version bump Version needs to be incremented or set to -DEV in Project.toml label Aug 25, 2022
mzgubic
mzgubic approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@mzgubic mzgubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need a version bump

@mcabbott mcabbott mentioned this pull request Aug 25, 2022
Open
@mcabbott mcabbott merged commit 13ccc86 into main Aug 25, 2022
@mcabbott mcabbott deleted the mcabbott-patch-3 branch August 25, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzgubic mzgubic mzgubic approved these changes

Assignees
No one assigned
Labels
needs version bump Version needs to be incremented or set to -DEV in Project.toml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcabbott @mzgubic