Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in 4 arg gemm rrule #272

Merged
merged 3 commits into from
Oct 1, 2020
Merged

fix typo in 4 arg gemm rrule #272

merged 3 commits into from
Oct 1, 2020

Conversation

oxinabox
Copy link
Member

This is a simple typo.
Clearly we have no tests for this rule.

This is blocking for invenia/Nabla.jl#189

willtebbutt
willtebbutt approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, yeah, might as well unblock you.

You should probably bump the patch as well though.

@oxinabox oxinabox changed the title fix typo in gemv rrule fix typo in 4 arg gemm rrule Oct 1, 2020
@oxinabox oxinabox merged commit 2be1af2 into master Oct 1, 2020
@oxinabox oxinabox deleted the ox/gemm branch October 16, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willtebbutt willtebbutt willtebbutt approved these changes

Assignees
No one assigned
Labels
needs-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oxinabox @willtebbutt