Fix signature for MersenneTwister #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrobinson251
approved these changes
Jul 6, 2020
|
Would it be possible to add a test for this? |
|
While fixing-up this code, would you mind also changing |
|
I think this fix is pretty hard to test. We'd need to test that we didn't accidentally define a rule for |
|
This fixes the issue for me, so i'll just merge and make a release since it's affecting Zygote and Flux. Thanks @sethaxen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (probably) fixes #227.
typeof(MersenneTwister)isDataType, so the rules introduced in #223 will be applied to many function calls.@baggepinnen can you confirm this resolves the issue for you?