Switch to Blue Style #165
Merged
Switch to Blue Style #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrobinson251
commented
Jan 26, 2020
| @@ -10,7 +10,7 @@ Requires = "ae029012-a4dd-5104-9daa-d747884805df" | |||
| Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2" | |||
|
|
|||
| [compat] | |||
| ChainRulesCore = "0.6" | |||
There was a problem hiding this comment.
Bumping to 0.6.1 allows us to remove the line using ChainRulesCore: AbstractZero
nickrobinson251
commented
Jan 26, 2020
| @scalar_rule(abs2(x), 2x) | ||
| @scalar_rule(exp(x), Ω) |
There was a problem hiding this comment.
Not required by Blue Style, but I alphabetised the blocks of code in this file, to make the rules easier to find (they are already in blocks of "similar" functions, but i fixed up a few inconsistencies in that too)
nickrobinson251
commented
Jan 26, 2020
| x::AbstractVector{T}) where T<:BlasFloat | ||
| function rrule( | ||
| ::typeof(gemv), tA::Char, A::AbstractMatrix{T}, x::AbstractVector{T} | ||
| ) where T<:BlasFloat |
There was a problem hiding this comment.
This is one of the few actual style changes -- it now matches the style we use everywhere else
oxinabox
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scalar_rules(although not required by the guide, seemed a good opportunity)