Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change convention for complex differentiation #210

Closed
8 tasks done
sethaxen opened this issue Jun 22, 2020 · 3 comments · Fixed by FluxML/Zygote.jl#721
Closed
8 tasks done

Change convention for complex differentiation #210

sethaxen opened this issue Jun 22, 2020 · 3 comments · Fixed by FluxML/Zygote.jl#721

Comments

@sethaxen
Copy link
Member

sethaxen commented Jun 22, 2020 •
edited
Loading

This issue tracks the necessary changes after JuliaDiff/ChainRulesCore.jl#167 is merged:

I have local implementations of most of these already.
@willtebbutt
Copy link
Member

Happy to help out anywhere that it would be useful, but you're probably the best placed to deal with these.

This was referenced Jun 22, 2020
Merged
Merged
@oxinabox
Copy link
Member

Update Zygote's adjoints to stop conjugating to/from ChainRules (breaking change)

This is not breaking for Zygote.
Its a nonbreaking feature to change what version of ChainRule's it supports

@sethaxen
Copy link
Member Author

Good point, thanks. Yes, if Zygote bumps the compat and stops conjugating to/from ChainRules at the same time, this is not a breaking change. I have updated.

This was referenced Jun 28, 2020
Merged
Merged
Merged
Merged
Merged
bors bot added a commit to FluxML/Zygote.jl that referenced this issue Jun 30, 2020
@bors @sethaxen
Merge #721
27da443 
721: Use ChainRules v0.7.0 r=oxinabox a=sethaxen

ChainRules v0.7.0 introduced a new convention for complex numbers. It is no longer necessary for Zygote to conjugate sensitivities sent to and received from ChainRules. This PR is a non-breaking change that uses ChainRules v0.7.0.

Fixes JuliaDiff/ChainRules.jl#210 and supersedes #720.

Co-authored-by: Seth Axen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ChainRules v0.7.0 sethaxen/Zygote.jl
3 participants
@willtebbutt @oxinabox @sethaxen