Merge pull request #616 from danielwe/redundantnorm

Eliminate redundant call to `norm`
JuliaDiff · May 13, 2022 · 30431b4 · 30431b4 · mzgubic · May 13, 2022
2 parents 3b3791f + 321f626
commit 30431b4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "ChainRules"
 uuid = "082447d4-558c-5d27-93f4-14fc19e9eca2"
-version = "1.30.0"
+version = "1.31.0"
 
 [deps]
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"

diff --git a/src/rulesets/LinearAlgebra/norm.jl b/src/rulesets/LinearAlgebra/norm.jl
@@ -4,7 +4,7 @@
 
 function frule((_, Δx), ::typeof(norm), x)
     y = norm(x)
-    return y, _norm2_forward(x, Δx, norm(x))
+    return y, _norm2_forward(x, Δx, y)
 end
 
 function frule((_, ẋ), ::typeof(norm), x::Number, p::Real)