Fix a Core.Box
#114
Merged
Fix a Core.Box
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is presumably a Julia limitation, but it seems that inner functions
get inferred as `Core.Box` if they call themselves. We can work around
it by splitting it out.
Specifically, in Cthulhu one sees
for p in preds
terminal_preds!::Core.Box(s, p, edges, covered)
end
when this is an inner function.
Keno
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is presumably a Julia limitation, but it seems that inner functions
get inferred as
Core.Boxif they call themselves. We can work aroundit by splitting it out.
Specifically, in Cthulhu one sees
when this is an inner function.
If this has been fixed on Julia nightly (JET doesn't work there so it is harder for me to check), then let's close this without merging.