feat: add TLS support #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds TLS support. An abstraction for the redis transport `RedisTransport` has been added. The existing TCP transport has been moved in as an implementation `TCPTransport <: RedisTransport`. A new TLS transport has been added as `TLSTransport <: RedisTransport`. This can in future be extended to support unix sockets too (ref: #84) fixes: #87
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 80.21% 82.76% +2.55%
==========================================
Files 6 9 +3
Lines 369 412 +43
==========================================
+ Hits 296 341 +45
+ Misses 73 71 -2 ☔ View full report in Codecov by Sentry. |
jkaye2012
reviewed
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds TLS support. An abstraction for the redis transport
RedisTransporthas been added. The existing TCP transport has been moved in as an implementationTCPTransport <: RedisTransport. A new TLS transport has been added asTLSTransport <: RedisTransport.This can in future be extended to support unix sockets too (ref: #84)
fixes: #87