Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store _jll lib names as consts #351

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Don't store _jll lib names as consts #351

merged 2 commits into from
Aug 18, 2022

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Aug 17, 2022

Fixes #350.

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #351 (2cfafc3) into main (88493b6) will decrease coverage by 0.68%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   75.68%   75.00%   -0.69%     
==========================================
  Files           6        6              
  Lines         835      856      +21     
==========================================
+ Hits          632      642      +10     
- Misses        203      214      +11     
Impacted Files Coverage Δ
src/ODBC.jl 68.75% <ø> (ø)
src/API.jl 57.48% <50.00%> (-1.47%) ⬇️
src/dbinterface.jl 92.82% <100.00%> (-1.30%) ⬇️
src/utils.jl 79.61% <100.00%> (+0.15%) ⬆️
src/load.jl 87.30% <0.00%> (+0.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@quinnj quinnj merged commit 4e0545d into main Aug 18, 2022
@quinnj quinnj deleted the jq/nonconstlibs branch August 18, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

could not load library ".../lib/libodbc.so"
1 participant