further demote diagnostics log output to debug #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
=======================================
Coverage 78.42% 78.42%
=======================================
Files 6 6
Lines 760 760
=======================================
Hits 596 596
Misses 164 164
Continue to review full report at Codecov.
|
|
Sounds good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using this a good while now, and this never stopped driving me nuts, and I think it's pretty safe to say that the kind of output it gives usually does not get printed by other database interfaces. In particular, it would spit output at me every time
ODBC.Connectionwas called, which was getting pretty annoying.I'm pretty sure pretty much everyone will be happier with these messages on
@debugrather than@info.