Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try only using SQLDriverConnect for connections #268

Merged
merged 2 commits into from
May 27, 2020
Merged

Try only using SQLDriverConnect for connections #268

merged 2 commits into from
May 27, 2020

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented May 27, 2020

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #268 into master will increase coverage by 1.12%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage   72.19%   73.32%   +1.12%     
==========================================
  Files           5        5              
  Lines         651      641      -10     
==========================================
  Hits          470      470              
+ Misses        181      171      -10     
Impacted Files Coverage Δ
src/API.jl 60.37% <60.00%> (+2.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4dd7ba...34e0c9d. Read the comment docs.

@quinnj
Copy link
Member Author

quinnj commented May 27, 2020

It turns out this resolves some other long-standing oddities because driver managers use an application's initial call of SQLDriverConnect or SQLDriverConnectW as a cue to whether it's a unicode application or not. It removes the need to special-case windows in the execute statements.

@quinnj quinnj merged commit df8ea6b into master May 27, 2020
@quinnj quinnj deleted the jq/ath branch May 27, 2020 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants