Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Not to delete! #2191

Merged
merged 2 commits into from
Apr 27, 2020
Merged

add Not to delete! #2191

merged 2 commits into from
Apr 27, 2020

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Apr 15, 2020

This is not urgent, but simple and will improve consistency.

@bkamins bkamins added the non-breaking The proposed change is not breaking label Apr 15, 2020
@bkamins bkamins added this to the 1.x milestone Apr 15, 2020
@bkamins
Copy link
Member Author

bkamins commented Apr 20, 2020

Thank you. I will rebase it and merge after #2199 is done

@bkamins bkamins merged commit 3c5013a into JuliaData:master Apr 27, 2020
@bkamins bkamins deleted the not_in_delete branch April 27, 2020 10:35
@bkamins
Copy link
Member Author

bkamins commented Apr 27, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
non-breaking The proposed change is not breaking
Projects
None yet
Milestone
1.x
Development

Successfully merging this pull request may close these issues.
2 participants
@bkamins @nalimilan