Port to CategoricalArrays 0.8 #602
Conversation
The change to `levels!` implies that all reference codes will be updated at the end to match the new order of levels (unless they were already sorted).
|
Can it be merged then? |
|
It needs DataFrames 0.21 to pass CI (EDIT: otherwise the dependencies cannot be satisfied). |
|
So this means that we have to coordinate releasing DataFrames.jl and CSV.jl? In this case maybe in this PR you can bump DataFrames.jl version and CSV.jl version in Project.toml? |
|
Well we have to release DataFrames first, and then ideally CSV.jl soon after that. If we don't do it, people who have CSV installed will stay at DataFrames 0.20, which isn't the end of the world but is... annoying. :-) But we also have to port many other packages, like RCall. |
|
I could do the next CSV release at any point now. I'm tracking down loose ends and kicking the tires on more speculative features; and I'm going to try to do another thorough review of performance/memory. But nothing release blocking. So I'll let @nalimilan drive a coordinated release for CategoricalArrays/DataFrames and CSV can tag along. |
|
@nalimilan, should we merge here and do a new release? |
|
We need to sync this with DataFrames.jl release. |
|
Ah right; I think in my mind, I was worried we were holding the DataFrames release because of this, but I suspect @nalimilan will known when to merge and then we can tag. |
|
The releases must be synced. We need to finish JuliaData/DataFrames.jl#2214 (complex) and JuliaData/DataFrames.jl#2196 (easy) and then we can make a release of DataFrames.jl. |
|
Version of CSV.jl in Project.toml needs to be changed also (unless you want to do it in a separate PR) |
|
CI looks good now - thank you! |
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
==========================================
+ Coverage 82.86% 84.53% +1.66%
==========================================
Files 9 9
Lines 1675 1513 -162
==========================================
- Hits 1388 1279 -109
+ Misses 287 234 -53
Continue to review full report at Codecov.
|
The change to
levels!implies that all reference codes will be updated at the end to match the new order of levels (unless they were already sorted).Requires the yet-to-be released CategoricalArrays 0.8.