-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PolynomialRatio docs. #495
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #495 +/- ##
=======================================
Coverage 97.46% 97.46%
=======================================
Files 18 18
Lines 3080 3080
=======================================
Hits 3002 3002
Misses 78 78 ☔ View full report in Codecov by Sentry. |
Bumping for a review. |
I think this is quite clear. But if possible, I would like to merge #526 first, rebase, then remove the |
We can just close the issue manually as well. |
It seems the doctests fail for this part even without #526, so the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix doctests
Agreed. Co-authored-by: wheeheee <[email protected]>
Co-authored-by: wheeheee <[email protected]>
Co-authored-by: wheeheee <[email protected]>
This PR updates the docs for PolynomialRatio as per #415.