Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PolynomialRatio docs. #495

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Update PolynomialRatio docs. #495

merged 5 commits into from
Feb 6, 2024

Conversation

kcin96
Copy link
Contributor

@kcin96 kcin96 commented Jan 9, 2023

This PR updates the docs for PolynomialRatio as per #415.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2637592) 97.46% compared to head (88900cd) 97.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #495   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files          18       18           
  Lines        3080     3080           
=======================================
  Hits         3002     3002           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Contributor

Bumping for a review.

@wheeheee
Copy link
Member

wheeheee commented Feb 5, 2024

I think this is quite clear. But if possible, I would like to merge #526 first, rebase, then remove the Polynomial. in these doctests so they pass?
Also, I'm not sure how GitHub keywords work; does @kcin96 need to edit their initial comment to mention that this closes #415 to close the issue automatically upon merge?

@ViralBShah
Copy link
Contributor

We can just close the issue manually as well.

@wheeheee
Copy link
Member

wheeheee commented Feb 5, 2024

It seems the doctests fail for this part even without #526, so the Polynomial.s need to go even if we want to merge now.

Copy link
Member

@wheeheee wheeheee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix doctests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants