-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: mark public names as public #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't say I love the idea of programmatically marking all functions as public that follow a given naming scheme instead of explicitly marking them as public, but I guess it's fine 😅
I don't disagree actually. In principle, this list could be turned into Lines 178 to 200 in c9a711d
and then we could check the naming convention in the tests. But it gets a bit annoying if we also have to support <= 1.10, since there's no way to list / filter for public names there. |
JuliaHub.jl follows the convention that all private names start with
_
, so we can do the loop automatically. There is still an list in the tests that we cross-check. Also, since we support all the way back to 1.6 right now, we need to make is conditional onBase.ispublic
being there (and this would stay true even if bump that to the 1.10 LTS).Will fix these warnings: