Handle empty message #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 82.71% 82.80% +0.08%
==========================================
Files 9 9
Lines 1030 1035 +5
==========================================
+ Hits 852 857 +5
Misses 178 178
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53
The problem is that the check for putting a completed message in the
recvqwas only done in the function that handlesBodyFrames but no body frame is sent when the message is empty. So I added a check in the processing ofHeaderFrameto handle the empty case.Edit: Sorry about the unnecessary commit, I merged thge old PR into my own fork before you pulled into master. I can recreate the PR if you want.