Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for stale connection while framing/chunking message to send #46

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

tanmaykm
Copy link
Member

This fixes a condition where sending a message on a stale connection can potentially get into an infinite loop while chunking a large message.

This fixes a condition where sending a message on a stale connection can potentially get into an infinite loop while chunking a large message.
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@d7bc69f). Click here to learn what that means.
The diff coverage is 57.37%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #46   +/-   ##
=========================================
  Coverage          ?   82.18%           
=========================================
  Files             ?        9           
  Lines             ?     1016           
  Branches          ?        0           
=========================================
  Hits              ?      835           
  Misses            ?      181           
  Partials          ?        0           
Impacted Files Coverage Δ
src/amqps.jl 0.00% <0.00%> (ø)
src/buffered_socket.jl 0.00% <0.00%> (ø)
src/spec.jl 0.00% <ø> (ø)
src/protocol.jl 87.03% <81.25%> (ø)
src/convert.jl 85.71% <83.33%> (ø)
src/types.jl 96.91% <83.33%> (ø)
src/auth.jl 100.00% <100.00%> (ø)
src/message.jl 91.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7bc69f...794f8ca. Read the comment docs.

@tanmaykm tanmaykm merged commit 6145773 into master Nov 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the tan/checkstaleconn branch November 15, 2021 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants