Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions to fixture CI files #443

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Add permissions to fixture CI files #443

merged 1 commit into from
Dec 15, 2023

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented Dec 15, 2023

Fix reference tests that were broken by #441

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebf6b9e) 70.66% compared to head (b142150) 92.91%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #443       +/-   ##
===========================================
+ Coverage   70.66%   92.91%   +22.24%     
===========================================
  Files          23       23               
  Lines         733      734        +1     
===========================================
+ Hits          518      682      +164     
+ Misses        215       52      -163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxinabox oxinabox merged commit 84bc934 into master Dec 15, 2023
13 checks passed
@oxinabox oxinabox deleted the gd/ci_perms branch December 15, 2023 12:34
@oxinabox
Copy link
Collaborator

Thankyou, my screw up for not checking the 1.7 CI
oops i should have approved and let you merge, sorry.

@gdalle
Copy link
Collaborator Author

gdalle commented Dec 15, 2023

no worries :) that's why there's several of us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants