Don't create empty Manifest.toml (again) #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
==========================================
- Coverage 93.13% 93.12% -0.01%
==========================================
Files 23 23
Lines 714 713 -1
==========================================
- Hits 665 664 -1
Misses 49 49
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
CI fails only on Julia 1.7.2, not sure is significant? Maybe this Manifest.toml should be removed from the reference test. Ref. #422. @nickrobinson251 can you take a look? Thanks. |
|
Yes that failure is real -- please see https://juliaci.github.io/PkgTemplates.jl/stable/developer/#Testing-1 and update the reference tests as needed (which you can do by running the reference tests locally with the required Julia version) |
|
Ref. test updated. All CI is green now! |
nickrobinson251
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #425. The
Gitplugin was alsotouching an empty Manifest.toml which also triggered the warning. This fixes that.