Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures from #304 #305

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Fix CI failures from #304 #305

merged 2 commits into from
Aug 18, 2021

Conversation

iamed2
Copy link
Member

@iamed2 iamed2 commented Aug 18, 2021

Fixes CI failures introduced in #304

Also brings this repo's own CI in line with the #304 change.

@iamed2 iamed2 requested a review from oxinabox August 18, 2021 20:21
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #305 (9a5ca76) into master (8438684) will increase coverage by 15.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #305       +/-   ##
===========================================
+ Coverage   79.17%   94.42%   +15.25%     
===========================================
  Files          20       20               
  Lines         605      610        +5     
===========================================
+ Hits          479      576       +97     
+ Misses        126       34       -92     
Impacted Files Coverage Δ
src/PkgTemplates.jl 100.00% <0.00%> (ø)
src/plugin.jl 98.38% <0.00%> (+0.02%) ⬆️
src/plugins/git.jl 95.08% <0.00%> (+4.91%) ⬆️
src/plugins/tests.jl 100.00% <0.00%> (+5.55%) ⬆️
src/plugins/documenter.jl 84.05% <0.00%> (+8.69%) ⬆️
src/plugins/tagbot.jl 100.00% <0.00%> (+11.11%) ⬆️
src/plugins/project_file.jl 88.88% <0.00%> (+22.22%) ⬆️
src/plugins/citation.jl 80.00% <0.00%> (+60.00%) ⬆️
src/plugins/ci.jl 98.66% <0.00%> (+80.00%) ⬆️
src/plugins/coverage.jl 90.90% <0.00%> (+90.90%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8438684...9a5ca76. Read the comment docs.

@iamed2 iamed2 merged commit 792243d into master Aug 18, 2021
@iamed2 iamed2 deleted the ed/cleanup-pr-304 branch August 18, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants