Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove L prefix before line segment of repo URL #248

Merged
merged 4 commits into from
Nov 19, 2020
Merged

Conversation

nickrobinson251
Copy link
Collaborator

i don't know how to explain this one... this L has been here a long time, but it seems unnecessary as it always results in URLs like https://github.com/etc..../foo.jl#LL1-2 with the double LL. Here's an example result of this change:

-https://github.com/invenia/PkgTemplates.jl/blob/89e6dd5e39641c8d40b2492d307e361a83b6dd0f/src/plugin.jl#LL155-L162
+https://github.com/invenia/PkgTemplates.jl/blob/89e6dd5e39641c8d40b2492d307e361a83b6dd0f/src/plugin.jl#L155-L162

I tested with Documenter 0.23, 0.24 and 0.25 and it always gives this same LL result.

As you can test for yourself using the two example links above, both work i.e. both link correctly to the source code of the PkgTemplates.tags(::Plugin) function.

However, the LL doesn't (or doesn't any longer??) work on GitLab. I don't have an open-source GitLab repo where i can show this, but somthing like https://gitlab.com/etc..../foo.jl#LL1-2 does not highlight lines 1-2 whereas https://github.com/etc..../foo.jl#L1-2 (with the single L) does highlight the intended lines.

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #248 (01321f9) into master (89e6dd5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   81.86%   81.86%           
=======================================
  Files          19       19           
  Lines         612      612           
=======================================
  Hits          501      501           
  Misses        111      111           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e6dd5...01321f9. Read the comment docs.

@christopher-dG
Copy link
Member

Turns out this has been outdated since Documenter 0.15! https://juliadocs.github.io/Documenter.jl/v0.14/lib/public/#Documenter.makedocs

Copy link
Member

@christopher-dG christopher-dG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference tests need updating. Thanks!

@nickrobinson251
Copy link
Collaborator Author

i don't have merge rights, but hopefully this is good to go :)

@christopher-dG christopher-dG merged commit 829d241 into master Nov 19, 2020
@christopher-dG christopher-dG deleted the npr/patch-1 branch November 19, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants