Remove L
prefix before line segment of repo URL
#248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i don't know how to explain this one... this
L
has been here a long time, but it seems unnecessary as it always results in URLs likehttps://github.com/etc..../foo.jl#LL1-2
with the doubleLL
. Here's an example result of this change:I tested with Documenter 0.23, 0.24 and 0.25 and it always gives this same
LL
result.As you can test for yourself using the two example links above, both work i.e. both link correctly to the source code of the
PkgTemplates.tags(::Plugin)
function.However, the
LL
doesn't (or doesn't any longer??) work on GitLab. I don't have an open-source GitLab repo where i can show this, but somthing likehttps://gitlab.com/etc..../foo.jl#LL1-2
does not highlight lines 1-2 whereashttps://github.com/etc..../foo.jl#L1-2
(with the singleL
) does highlight the intended lines.