Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to evaluate package loadability. #272

Merged
merged 10 commits into from
Jan 6, 2025
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Dec 6, 2024

Use that as the fallback for blacklisted packages.

Fixes #271
Will only deploy next week.

@maleadt maleadt changed the title Make it possible to unload load packages. Make it possible to evaluate package loadability. Dec 9, 2024
@maleadt
Copy link
Member Author

maleadt commented Dec 9, 2024

Example report: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/e0656ac/report.html

This will need some additional fixes across the PkgEval stack to ensure status=:ok reason=:loaded isn't rendered as positively as reason=:tested.

@KristofferC Thoughts on this change? It was motivated by having additional coverage on loadability of packages when they're blacklisted because of test failures, but we'll need to be careful that it's clearly shown as such.

@maleadt
Copy link
Member Author

maleadt commented Dec 15, 2024

This regressed PkgEval times from 10h to 18h, so I'll likely revert this.

Example run: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/3124e4e_vs_309021d/report.html

@maleadt maleadt force-pushed the tb/run_tests branch 2 times, most recently from 8f14577 to be75e2c Compare December 16, 2024 11:44
@maleadt
Copy link
Member Author

maleadt commented Dec 20, 2024

Switching to not using TestEnv, but only compiling the actual package, results in much better timings: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/3236e12_vs_17857ca/report.html

I wonder if somethings up here, or if it's really test dependencies accounting for so much of the total PkgEval time...

EDIT: Oh, looks like GitHub had an outage and many packages weren't tested...

@maleadt
Copy link
Member Author

maleadt commented Jan 6, 2025

Here's a more realistic run: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/1dd25f0_vs_5ee67b8/report.html

So it regressed from 10 to 15h, which I guess is fair considering how much additional packages were covered:

In total, 10154 packages were evaluated, out of which 5246 successfully tested, 2723 were not tested but did load successfully, 45 crashed, 1264 failed and 876 were skipped.

@maleadt maleadt marked this pull request as ready for review January 6, 2025 12:51
@maleadt maleadt merged commit 5458bdb into master Jan 6, 2025
6 checks passed
@maleadt maleadt deleted the tb/run_tests branch January 6, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider testing loadability of blacklisted packages
1 participant