WIP: Benchmark flatten #234
Conversation
| ############################################### | ||
| # flatten iterator | ||
|
|
||
| g = addgroup!(SUITE, "iterators", ["flatten"]) |
There was a problem hiding this comment.
This overwrites the other "iterators" group defined above, which was likely not your intent.
Instead, it would probably make sense just to add these benchmarks to this existing "iterators" group (e.g. just delete g = addgroup!(SUITE, "iterators", ["flatten"]), add "flatten" as a tag to the existing group, and remove the comment separator).
There was a problem hiding this comment.
Sorry about that.
Would it make sense for addgroup! to error in this case?
There was a problem hiding this comment.
Hehe, I tend to think that would be a good idea ;-)
There was a problem hiding this comment.
Would it make sense for addgroup! to error in this case?
Yeah, this would probably be more useful than the current behavior, which is for addgroup!(suite, id, args...) to be a convenience function implementing g = BenchmarkGroup(args...); suite[id] = g; g.
This reverts commit d77f701.
|
@mschauer I reverted this based on the comments by Jarrett. |
|
Thank you for the help, fixed and rebased at #237 |
* Show trials with 1 sample without error When only a single sample is present, show the info on that one result. Also use plurals appropriately with sample(s) and evaluation(s). * Add test for displaying single-sample trial
I think I do not understand the concept of
addgroup!correctly, help welcome. In any case, these Benchmarks would be useful with JuliaLang/julia#29786 in mind.