-
Notifications
You must be signed in to change notification settings - Fork 45
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add additional required copies for opt_call, but disable it
Reverts #308, as this still seems insufficient to make evals>1 work correctly.
- Loading branch information
Showing
1 changed file
with
12 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1bc6851
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aviatesk I meant to make this a PR for your comment, but then accidentally pushed it directly. I suppose it doesn't matter, since this isn't the nanosoldier branch anyways. I also added branch protection for master, so accidental pushes won't happen again to it.
1bc6851
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if we revert the PR and comment it out, the problem will not be solved (since
evals
needs to be used as a keyword in the@benchmarkable
macro). Should we revert this commit as well for now?1bc6851
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping to fix it (since right now it crashes in inlining with the fixes, and in the verifier without them), but couldn't figure out the inlining bug and realized I didn't really need this to fix nanosoldier for now