Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ConcreteStructs and simplify SimpleOrbit constructer #27

Merged
merged 4 commits into from
Oct 17, 2021

Conversation

mileslucas
Copy link
Member

in response to #23 (comment)

this should be non-breaking, so we can just update the patch version.

@mileslucas mileslucas requested a review from icweaver October 15, 2021 21:58
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #27 (b679225) into main (262e2d8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   91.00%   90.99%   -0.02%     
==========================================
  Files          12       12              
  Lines        1012     1010       -2     
==========================================
- Hits          921      919       -2     
  Misses         91       91              
Impacted Files Coverage Δ
src/Transits.jl 88.88% <ø> (ø)
src/orbits/Orbits.jl 100.00% <ø> (ø)
src/orbits/simple.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262e2d8...b679225. Read the comment docs.

Copy link
Member

@icweaver icweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, ConcreteStructs.jl looks like a super cool package! Looking forward to adding this to KeplerianOrbit. I guess no more {T,L,D,R,A,I,M}, haha

btw, local tests look good on my end. Didn't know about Aqua.jl, it looks really useful too!

@mileslucas mileslucas merged commit 8dddf7a into main Oct 17, 2021
@mileslucas mileslucas deleted the ml/simple-struct branch October 17, 2021 00:43
@mileslucas
Copy link
Member Author

I'm excited for ConcreteStructs.jl, too. I'm hoping we don't see any issues, cause it saves so much unnecessary type-ing. Yeah, I've been adding Aqua.jl to CI. I've been pretty satisfied with the coverage it adds, although the ambiguities tests fail with anything using ChainRulesCore; I don't know why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants