Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move infinite conv from InfiniteLinearAlgebra to DSP extension #137

Merged
merged 3 commits into from
Jul 29, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jul 29, 2023

These were being defined in InfiniteLinearAlgebra through type-piracy, but they may be defined here in a package extension.

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #137 (53c1e4c) into master (923fc66) will increase coverage by 0.19%.
Report is 2 commits behind head on master.
The diff coverage is 91.42%.

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   85.69%   85.89%   +0.19%     
==========================================
  Files           5        6       +1     
  Lines         706      730      +24     
==========================================
+ Hits          605      627      +22     
- Misses        101      103       +2     
Files Changed Coverage Δ
src/InfiniteArrays.jl 86.66% <ø> (ø)
ext/InfiniteArraysDSPExt.jl 91.42% <91.42%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dlfivefifty
Copy link
Member

We probably have to tag this as v0.13 to avoid overwriting existing functions errors

@jishnub jishnub merged commit 6a718b4 into JuliaArrays:master Jul 29, 2023
@jishnub jishnub deleted the infconv branch July 29, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants