Skip to content

Define dataids for PseudoBlockArrays (#364) #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Apr 1, 2024

Reland #364, but this time it's added to the release-1.0 branch as this is breaking for LazyBandedMatrices. The breakage actually arises from LinearAlgebra not suporting broadcasting over blocked structured matrices (JuliaLang/LinearAlgebra.jl#985) and should be fixed by JuliaLang/julia#53909

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.82%. Comparing base (ab3dce9) to head (c62d761).
Report is 27 commits behind head on release-1.0.

❗ Current head c62d761 differs from pull request most recent head 963aefd. Consider uploading reports for the commit 963aefd to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.0     JuliaLang/julia#374   +/-   ##
============================================
  Coverage        94.81%   94.82%           
============================================
  Files               16       16           
  Lines             1505     1506    +1     
============================================
+ Hits              1427     1428    +1     
  Misses              78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub closed this Apr 7, 2024
@jishnub jishnub force-pushed the jishnub/pseudoblockdataids branch from 963aefd to 4a7b1df Compare April 7, 2024 14:28
@jishnub jishnub deleted the jishnub/pseudoblockdataids branch April 7, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant