Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maximum(abs, ::Fun) #570

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 22, 2023

Fix JuliaApproximation/ApproxFun.jl#907

After this,

julia> x = Fun()
Fun(Chebyshev(), [0.0, 1.0])

julia> a = abs(x)
Fun(ContinuousSpace{Float64, Float64, PiecewiseSegment{Float64, Vector{Float64}}}(PiecewiseSegment{Float64, Vector{Float64}}([-1.0, -0.0, 1.0])), [1.0, 5.55112e-17, 1.0])

julia> using LinearAlgebra

julia> norm(x - a, Inf)
2.0

julia> norm(a - x, Inf)
2.0

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 21.73% and project coverage change: -0.03% ⚠️

Comparison is base (c31337a) 27.53% compared to head (74e44f0) 27.51%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
- Coverage   27.53%   27.51%   -0.03%     
==========================================
  Files          80       80              
  Lines        8379     8382       +3     
==========================================
- Hits         2307     2306       -1     
- Misses       6072     6076       +4     
Files Changed Coverage Δ
src/Operators/Operator.jl 51.98% <0.00%> (ø)
src/Operators/banded/CalculusOperator.jl 17.21% <0.00%> (ø)
src/Spaces/SumSpace.jl 31.98% <0.00%> (ø)
src/specialfunctions.jl 16.77% <0.00%> (ø)
src/Operators/general/InterlaceOperator.jl 23.56% <50.00%> (+0.09%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit e1e8cf9 into JuliaApproximation:master Aug 22, 2023
@jishnub jishnub deleted the maxabs branch August 22, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing operand order causes incorrect calculation of the infinity norm
1 participant