Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show for QuotientSpace #785

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jul 28, 2022

Fix for bug introduced by #781. After this, the following work:

julia> QuotientSpace(Dirichlet(Chebyshev()))
Chebyshev() /
 1.0  -1.0  1.0  -1.0  1.0  -1.0  1.0  -1.0  1.0  -1.0  
 1.0   1.0  1.0   1.0  1.0   1.0  1.0   1.0  1.0   1.0  

julia> show(Q)
Chebyshev() /
ConcreteDirichlet : Chebyshev()  2-element ArraySpace:
ConstantSpace{DomainSets.Point{Float64}, Float64}[ConstantSpace(Point(-1.0)), ConstantSpace(Point(1.0))]

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #785 (d55e833) into master (7968dab) will increase coverage by 3.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   31.29%   34.85%   +3.55%     
==========================================
  Files          15       15              
  Lines         850      855       +5     
==========================================
+ Hits          266      298      +32     
+ Misses        584      557      -27     
Impacted Files Coverage Δ
src/Extras/show.jl 38.55% <100.00%> (+18.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7968dab...d55e833. Read the comment docs.

@jishnub jishnub merged commit e4787f2 into JuliaApproximation:master Jul 28, 2022
@jishnub jishnub deleted the showfix branch July 28, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant