Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move show methods to ApproxFunBase #784

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jul 28, 2022

This reduces the extent of type-piracy in this package.

@jishnub jishnub marked this pull request as draft July 28, 2022 08:59
@jishnub jishnub closed this Jul 28, 2022
@jishnub jishnub reopened this Jul 28, 2022
@jishnub
Copy link
Member Author

jishnub commented Jul 28, 2022

CI will only pass after all dependencies have been updated to accept ApproxFunBase v0.6

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #784 (671bc04) into master (e4787f2) will decrease coverage by 0.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
- Coverage   34.85%   34.27%   -0.58%     
==========================================
  Files          15       15              
  Lines         855      744     -111     
==========================================
- Hits          298      255      -43     
+ Misses        557      489      -68     
Impacted Files Coverage Δ
src/Extras/show.jl 38.18% <ø> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4787f2...671bc04. Read the comment docs.

@jishnub jishnub marked this pull request as ready for review August 1, 2022 05:44
@jishnub jishnub merged commit 2fffa7d into JuliaApproximation:master Aug 1, 2022
@jishnub jishnub deleted the showtrim branch August 1, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant