Loosen IntervalSets.jl compat #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, newer IntervalSets versions are slower and result in more allocations – see JuliaMath/IntervalSets.jl#168. Noticed when I ran FlexiJoins tests – they fail on Julia 1.10 with newer IntervalSets because of much more allocations. |
|
Hmm it fails even on 1.11... :( |
|
indeed, unfortunately the new IntervalSets versions lead to performance issues on both 1.10 and 1.11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the tightening was done in 961aa6c but I couldn't find any context as to why...