Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CategoricalDistributions for UnivariateFinite, instead of MLJBase #13

Merged
merged 6 commits into from
Dec 27, 2021

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Dec 13, 2021

This PR needs:

  • MLJBase 0.19 released
  • Version updated to 0.2.0

In this PR, we:

  • Add CategoricalDistributions.jl as a dependency
  • Bump compat for MLJBase to 0.19 and address the fact that UnivariateFinite functionality is not defined in MLJBase 0.19, but in CategoricalDistributions.jl instead.
  • (breaking) Change syntax EnsembleModel(atom=...) to EnsembleModel(model=...) for consistency with other MLJ model wrappers (eg, TunedModel) but additionally allow passing model as non-keyword argument, as in EnsembleModel(my_tree, ...).

@ablaom ablaom mentioned this pull request Dec 17, 2021
18 tasks
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2021

Codecov Report

Merging #13 (da40e11) into dev (7ca66d7) will increase coverage by 8.04%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #13      +/-   ##
==========================================
+ Coverage   70.46%   78.50%   +8.04%     
==========================================
  Files           2        2              
  Lines         237      214      -23     
==========================================
+ Hits          167      168       +1     
+ Misses         70       46      -24     
Impacted Files Coverage Δ
src/MLJEnsembles.jl 100.00% <ø> (ø)
src/ensembles.jl 78.40% <70.00%> (+8.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ca66d7...da40e11. Read the comment docs.

@ablaom ablaom merged commit ad9b756 into dev Dec 27, 2021
@ablaom ablaom mentioned this pull request Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants