For a 0.17.0 release #508
Merged
For a 0.17.0 release #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better error for bad call of transform on machines for Static models
add fit_only! logic that caches reformatted/resampled user-data add test minor comment change "Bump version to 0.16.3" resolve #499 add test add tests for reformat front-end oops add model api tests for reformat front-end tidy up add test for reformat logic in learning network context do not update state of a Machine{<:Static} on fit! unless hyperparams change add tests allow speedup buy-out with machine(model, args..., cache=false) oops have KNN models buy into reformat data front-end for better testing introduce "back-end" resampling in evaluate! implement data front-end on prediction/transformation side update machine show more tests; add cache=... to evaluate(model, ...) more tests make `cache` hyperparam of Resampler for passing onto wrapped machines more tests Composite models do not cache data by default (no benefit) correct comment bump [compat] MLJModelInterface = "^0.3.7" (essential)
forgotten
Code re-organization
Realize performance improvements for models implementing new data front-end
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
==========================================
+ Coverage 82.71% 83.04% +0.32%
==========================================
Files 39 37 -2
Lines 2934 2914 -20
==========================================
- Hits 2427 2420 -7
+ Misses 507 494 -13
Continue to review full report at Codecov.
|
|
@JuliaRegistrator register |
|
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code re-organization:
measures(matching(...))facility removed; privateinfo_dicmethod andmatchingmethod moved to MLJModelsAlso added optimisations for models buying into a new data front-end #501 . This may increase the default memory footprint of MLJBase operations.