Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update alpine base image #5

Merged
merged 3 commits into from
Aug 12, 2021
Merged

chore: update alpine base image #5

merged 3 commits into from
Aug 12, 2021

Conversation

h1dden-da3m0n
Copy link
Contributor

Description

I noticed that the base image was a very outdated Alpine version, so I updated that and added a Dependabot config to always keep it up to date (monthly check, can be set to daily too but seemed too excessive).
Since I am a big fan of editorconfigs I also added that one, however I can always revert that commit if you want me to 😉

Side-note: since there is already CI to build the Image a regular vulnerability scan via the likes of the Trivy Action could be an interesting thing too.

Change(s)

  • update base image from alpine 3.11 to 3.14.1 (latest)
  • add dependabot to monthly check for newer alpine versions
  • add editorconfig for easy uniform formatting

Issue(s)

  • n/a

@JoshPiper
Copy link
Owner

Hey hey, cheers for the commits.

Updating the base image was something that, to be honest, I never really thought about so long as it "just worked":tm:, so that's really appreciated.

The editor config I'll probably change a tad since uhhhhhhhhhhhhhhhhh tabs>spaces ;), but also very much appreciated.

For scanning, it would be interesting, but I'm not entirely sure on the utility, due to builds only happening on release, it'd have to be set up as a recurring job to be useful, in my opinion there. For sure something to look into, and could very much be useful.

@JoshPiper JoshPiper merged commit b342796 into JoshPiper:master Aug 12, 2021
@h1dden-da3m0n h1dden-da3m0n deleted the chore/update-alpine branch August 12, 2021 16:28
@h1dden-da3m0n
Copy link
Contributor Author

Hey ty for the merger 🎉
yeah the base image unfortunately gets easily forgotten and turns into a security risk eventually (alpine maybe not as much as others, but still)
On the tabs, lets just conclude with: Let's agree to disagree 😅
Finally, regarding some inspiration checkout this repo in regards of a scan workflow. However, this will only open Security reports which IIRC wont trigger any GH notifications, so that may need a bit more thought 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants