Player InputController에서 Input EventCallback 구현 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongfeel
approved these changes
Jul 10, 2021
| switch(e.keyCode) | ||
| { | ||
| case KeyCode.RightArrow: | ||
| DirectoinInput?.Invoke(InputInfo.Right); |
There was a problem hiding this comment.
다시 보니까 InputInfo 대신에 그냥 KeyCode를 전달하는 것도 괜찮을 듯 합니다.
그러면 이런 switch case문은 안만들어도 되니까요.
There was a problem hiding this comment.
네네 KeyCode Enum이 있는 것을 하다가 깨달았습니다 ㅋㅋ
위 부분은 실제 게임 화면 작업할 때 반영할게요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 내용
Event를 활용해서 현재 눌린 키값에 따라 EventCallback을 하도록 했습니다.
리펙토링
하드 코딩으로 값을 가지고 오는 경우가 보이더라구요
nameof연산자를 활용해서 리펙토링을 조금 해보았습니다.