Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: implement logger the project #84

Merged
merged 11 commits into from
Jun 14, 2023
Merged

enhancement: implement logger the project #84

merged 11 commits into from
Jun 14, 2023

Conversation

SamantaTarun
Copy link
Member

@SamantaTarun SamantaTarun commented Jun 6, 2023

Closes #64

SS:
image

Current Behaviour:

The current project has random print everywhere in the app.
Expected Behaviour:

Implement a proper logger in the project :100

Use the logger package from pub.dev https://pub.dev/packages/logger

Replace the print() methods in the entire project with the corresponding log

Debug
Error
Verbose

Steps to Reproduce:

NO/
Environment:

Emulator: Pixel 6 Pro
Android version: 12
Android SDK: 33

@SamantaTarun SamantaTarun changed the title enhancement: implement loggersto the project enhancement: implement logger the project Jun 6, 2023
@JordyHers JordyHers changed the base branch from master to dev June 6, 2023 06:24
@JordyHers JordyHers self-requested a review June 6, 2023 06:24
@SamantaTarun
Copy link
Member Author

@JordyHers i think everything has been completed.

@JordyHers
Copy link
Contributor

@tarunsamanta2k20 i will then review and merge. It. Thank you so much 😁🙏 Tarun for your contribution.

@JordyHers JordyHers requested a review from i-am-ijaz June 14, 2023 06:58
Copy link
Contributor

@JordyHers JordyHers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loogs good to me loggers use the correct types.

@JordyHers JordyHers merged commit db955a2 into JordyHers-org:dev Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement loggers to the project
2 participants