Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#52) : fixes the app loading as well as validator issue #82

Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix(#52) : fixes the app loading as well as validator issue #82

merged 1 commit into from
Jun 6, 2023

Conversation

i-am-ijaz
Copy link
Contributor

What Changed

  • Loading indicator should appear immediately as soon as user clicks on the save button
  • Validation errors should be visible to the user when email and child name will be empty

@JordyHers JordyHers self-requested a review June 5, 2023 19:53
JordyHers
JordyHers approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@JordyHers JordyHers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@i-am-ijaz i-am-ijaz merged commit 17fc030 into dev Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordyHers JordyHers JordyHers approved these changes

Assignees

@JordyHers JordyHers

Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i-am-ijaz @JordyHers