-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Dev into Master #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #129 from JordyHers-org/dev
…-app-is-not-responsive Bugfix/131 the font in the app is not responsive
…nd-add-real-time-statistics
…y-widget-to-the-project feat(#138) : implements a battery widget.
…e-area-issues Bugfix/134 UI overflow safe area issues
…dd-real-time-statistics Feature/17 calculate and add real time statistics
…etails_page Chore/141 refactor child details page
Chore/20 implement flavors
…go-hidden-in-app chore(#145) : implement JordyHers logo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE⚠️
Hi team,
I have reviewed the latest changes in the pull request, and I noticed that there have been significant updates to the app architecture by incorporating flavors. This is a major change that impacts various aspects of the application.
With the introduction of flavors, different flavors of the app can now be built, each with its own configuration and behavior. This allows us to customize the app for different environments, such as development, staging, and production.
However, please note that due to the implementation of flavors, the sign-in functionality has been affected, and currently, signing in is not available. The Firebase authentication system has been reimplemented as part of these changes. To get more detailed information about this modification and its implications, I recommend reaching out to the code owner responsible for these updates.
Overall, the addition of flavors brings flexibility and scalability to the app architecture, enabling easier configuration management across different environments. It's essential to ensure thorough testing and verification of the new changes to guarantee a smooth transition.
If you have any questions or need further clarification regarding these updates, please don't hesitate to ask the code owner or leave your comments here.
Thank you! @JordyHers-org/dev-team