Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when notification has null timestamp #220

Closed
ckelwin opened this issue Oct 22, 2023 · 0 comments
Closed

Error when notification has null timestamp #220

ckelwin opened this issue Oct 22, 2023 · 0 comments
Assignees
@ckelwin
Labels
bugfix-branch hacktoberfest ⛏️ HacktoberFest contributions
Milestone
v.2.0.0

Comments

@ckelwin
Copy link
Collaborator

ckelwin commented Oct 22, 2023

Describe the bug
The timestamp on Notification is nullable and causes error on the Notifications page.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Notifications' page. There should have been a notification sent previously without timestamp. Will need a way to reproduce this.
  2. See error in screenshot below.

Expected behavior
If it's nullable, then there should not be error when displaying on page and we should show empty string.

Screenshots
image

REMARK:

  • Also updated the timestamp formatting, as previously for "1930", it was showing "19:30PM", instead of "07:30PM".
@ckelwin ckelwin self-assigned this Oct 22, 2023
ckelwin added a commit that referenced this issue Oct 22, 2023
@ckelwin
fix(#220): Fixed error when notification has null timestamp. Updated …
cba844c 
…datetime formatting to show time correctly for 'PM'.
@ckelwin ckelwin mentioned this issue Oct 22, 2023
Merged
@JordyHers JordyHers added this to the v.2.0.0 milestone Oct 23, 2023
@JordyHers JordyHers moved this from Backlog to Done in Time's up Flutter Oct 23, 2023
@JordyHers JordyHers added bugfix-branch hacktoberfest ⛏️ HacktoberFest contributions labels Oct 23, 2023
@JordyHers JordyHers moved this from Done to In Progress in Time's up Flutter Oct 23, 2023
JordyHers added a commit that referenced this issue Oct 23, 2023
@JordyHers
Merge pull request #221 from JordyHers-org/bugfix/220-error-when-noti…
b71cf66 
…fication-has-null-timestamp

fix(#220): error when notification has null timestamp
@github-project-automation github-project-automation bot moved this from In Progress to ready-for-testing in Time's up Flutter Nov 1, 2023
@JordyHers JordyHers moved this from ready-for-testing to Done in Time's up Flutter Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckelwin ckelwin

Labels
bugfix-branch hacktoberfest ⛏️ HacktoberFest contributions
Projects
Time's up Flutter
Archived in project
Milestone
v.2.0.0
Development

No branches or pull requests
2 participants
@ckelwin @JordyHers