Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use world-space center of mass in penetration constraint #81

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Use world-space center of mass in penetration constraint #81

merged 1 commit into from
Jul 17, 2023

Conversation

Jondolf
Copy link
Owner

@Jondolf Jondolf commented Jul 17, 2023

The center of mass used in PenetrationConstraint was local when it should have been in world space.

@Jondolf Jondolf added bugfix A-Dynamics Relates to rigid body dynamics: motion, mass, constraint solving, joints, CCD, and so on labels Jul 17, 2023
@Jondolf Jondolf merged commit 4b04ce9 into main Jul 17, 2023
@Jondolf Jondolf deleted the contact-center-of-mass-fix branch July 17, 2023 19:31
DanielHZhang pushed a commit to DanielHZhang/bevy_xpbd that referenced this pull request Oct 9, 2023
@Jondolf @DanielHZhang
Use world-space center of mass in penetration constraint (Jondolf#81)
bd4c633 
Found by LeshaInc
@Jondolf Jondolf added C-Bug Something isn't working and removed bugfix labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Dynamics Relates to rigid body dynamics: motion, mass, constraint solving, joints, CCD, and so on C-Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jondolf