Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CollisionLayers methods with_group, without_group etc. to add_group, remove_group #62

Merged
merged 2 commits into from
Jul 8, 2023
Merged

Rename CollisionLayers methods with_group, without_group etc. to add_group, remove_group #62

merged 2 commits into from
Jul 8, 2023

Conversation

Jondolf
Copy link
Owner

@Jondolf Jondolf commented Jul 8, 2023 •
edited
Loading

Renames collision layer methods to be clearer and adds remove_groups and remove_masks.

  • with_mask → add_mask
  • with_masks → add_masks
  • without_mask → remove_mask and remove_masks
  • with_group → add_group
  • with_groups → add_groups
  • without_group → remove_group and remove_groups

@Jondolf
Rename with_group, without_group etc. to add_group, remove_group
6730c98 
This makes it clearer that the `CollisionLayers` methods are additive
and it's closer to Bevy's naming conventions.

Also added `remove_groups` and `remove_masks`.
@Jondolf Jondolf added the C-Enhancement New feature or request label Jul 8, 2023
@Jondolf Jondolf merged commit 8a28537 into main Jul 8, 2023
@Jondolf Jondolf deleted the collision-layers-method-names branch July 8, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jondolf