Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Transform instead of Position and Rotation in examples #201

Merged
merged 95 commits into from
Oct 28, 2023
Merged

Use Transform instead of Position and Rotation in examples #201

merged 95 commits into from
Oct 28, 2023

Conversation

Jondolf
Copy link
Owner

@Jondolf Jondolf commented Oct 27, 2023

Objective

Using Transform instead of the separate Position and Rotation components is more idiomatic and familiar for Bevy users, but currently the examples use the separate components. This also adds a lot of usage of feature-dependent math types like Vector, which can be a bit more confusing.

Solution

Use Transform in all examples except where Position should be used for stability (in systems that run in the SubstepSchedule).

@Jondolf
Fix contact points in penetration computation
32fd960
@Jondolf
Update child collider positions based on parent
703748d
@Jondolf
Fix compound collider contact points
984b4b6
@Jondolf
Only debug render axes for rigid bodies
f43c94a
@Jondolf
Add ColliderParent and implement child collider collisions
f0f4f6f
@Jondolf
Allow sensors, custom friction and restitution for child colliders
9cf7c51
@Jondolf
Fix subshape rotations
5976ee6
@Jondolf
Document ColliderParent
7d3d9b4
@Jondolf
Support arbirarily deep collider nesting and improve stability
a21db10
@Jondolf
Fix lints
7aafd37
@Jondolf
Fix lints
d015e88
@Jondolf
Merge branch 'main' into child-colliders
a69d0b6
@Jondolf
Fix child collider initial position
bc762f3
@Jondolf
Register ColliderMassProperties and PreviousColliderOffset
2e0dab6
@Jondolf
Remove unnecessary components from colliders without RigidBody
1ebb48d
@Jondolf
Improve Collider documentation and document child colliders
bbd4618
@Jondolf
Fix missing delimiter in docs
28db07a
@Jondolf
Wake up bodies when child colliders are transformed
81bdf3b
@Jondolf
Fix missing delimiter in docs again
4332248
@Jondolf
Improve ColliderParent docs
85c66d2
@Jondolf
Merge branch 'main' into child-colliders
3f586c0
@Jondolf
Correctly handle removing colliders from rigid bodies
362d0bf 
It now wakes up bodies and subtracts from their mass properties.

Since we can't access components of despawned entities, I added
a `ColliderStorageMap` for now.

It might not be optimal, but it can be improved later.
Ideally we'd use hooks/callbacks once they're implemented in Bevy.
@Jondolf
Reset ColliderParent and ColliderOffset when rigid body is removed
6af30ab
@Jondolf
Automatically add and remove ColliderParent and ColliderOffset
c57db60
@Jondolf
Change 2D examples to use Transform instead of Position
b0b8187
@Jondolf
Merge branch 'main' into child-colliders
0d6b948
@Jondolf
Merge branch 'main' into child-colliders
8ed6dd7
@Jondolf
Merge branch 'main' into child-colliders
a1783dc
@Jondolf
Refactor collider logic in penetration_constraints
be762d2
@Jondolf
Merge branch 'main' into child-colliders
890ac0b
Jondolf added 18 commits October 22, 2023 00:24
@Jondolf
Fix code example in docs
cdd4fb1
@Jondolf
Make ColliderParent optional in some systems
13c033c
@Jondolf
Merge branch 'child-colliders' into collider-scale
9b0a2f6
@Jondolf
Merge branch 'collider-scale' into async-colliders
97b2bae
@Jondolf
Fix doc code example
47e0f0a
@Jondolf
Rename AsyncSceneCollider methods and support collision layers
f9d57a8
@Jondolf
Merge branch 'main' into async-colliders
a70d5e8
@Jondolf
Refactor and support density for AsyncSceneCollider
2277b2b
@Jondolf
Add async_colliders example and Ferris model
5a31e54
@Jondolf
Remove PreviousColliderMassProperties and fix mass props for children
80b9892
@Jondolf
Update densities in async_collider example
49f3a28
@Jondolf
Fix transform change detection
aa77497
@Jondolf
Use separate methods instead of single from_mesh for Collider
12bb212
@Jondolf
Fix lint
d2e3c8b
@Jondolf
Fix code example
d024391
@Jondolf
Merge branch 'async-colliders' into transform-in-docs-and-examples
72f3b4b
@Jondolf
Use Transform instead of Position in 3D examples
e00e71d
@Jondolf
Update README.md code example
a4ab636
@Jondolf Jondolf added C-Enhancement New feature or request C-Examples Improvements or additions to examples labels Oct 27, 2023
@Jondolf Jondolf merged commit d1d8e71 into main Oct 28, 2023
@Jondolf Jondolf deleted the transform-in-docs-and-examples branch October 28, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-Enhancement New feature or request C-Examples Improvements or additions to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jondolf